+- Wings 3D Development Forum (https://www.wings3d.com/forum)
+-- Forum: Wings 3D (https://www.wings3d.com/forum/forumdisplay.php?fid=1)
+--- Forum: Design & Development (https://www.wings3d.com/forum/forumdisplay.php?fid=6)
+--- Thread: YafaRay Plug-in - reviewing for Yafaray 3.0 (/showthread.php?tid=2053)
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - david.bluecame - 07-21-2016
Hello,
Yes, I fully agree with that idea, I hope you don't have to change too many things after I update the plugin ;-)
About the crash, you need the upcoming YafaRay v3.0.1-beta to be able to use the passes from Wings3D plugin, as I'm making changes in YafaRay Core to better support Render Passes from plugins other than Blender-Exporter. I hope I can release it soon!
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - oort - 07-21-2016
Micheus,
Maybe you need to add "-pbp none" (without quotes) to the options line when configuring the YafaRay plugin. This is needed until we get the update. I think the error you list is the one I was getting before adding that to my plugin settings.
oort
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - micheus - 07-21-2016
Thanks oort. That's did the trick.
David, I fixed the layout problem as well as the non saved values.
I was wrong about to use the key function for this situation. Only checking the code I saw I was talking about the wrong way the function is used. In this case you were right - we don't need to use it.
If you don't have any update to the current code at github I can attach the fixed source file. Or maybe you want to update it and I can transfer the changes and then attach the file.
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - david.bluecame - 07-21-2016
If you send me a private message with your e-mail I can add you to my Wings fork and we can "play" there together. When you, oort and me are happy with it (eventually) I will send a pull request against the official wings. What do you think?
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - micheus - 07-21-2016
I just did a pull request to you.
Ops, wait a minute. Something was missing.
----
Dam, by fetching my branch I loose the changes. Sorry. That will take a few minutes to be fixed.
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - david.bluecame - 07-21-2016
No worries, take your time! :-) I added you to my fork so you can push directly
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - micheus - 07-21-2016
It's ok now. It was saved in the branch I was working (not in the clone of yours), so I just recovered it.
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - david.bluecame - 07-21-2016
Do you want me to merge the pull request now?
(I think you can merge it too now as you are a collaborator of my fork)
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - micheus - 07-21-2016
I do prefer you do that. It's a good idea only the owner manage that.
RE: YafaRay Plug-in - reviewing for Yafaray 3.0 - david.bluecame - 07-21-2016
Done, and seems to work very well, and a lot more tidy!! Thank you! :-)