[fixed] Crash when move a SpotLight object.

[tkbd]

hi! I had the opportunity to use Windows PC the other day and install Wings3D.

So,I tried to several texture mapping to an object. (metallic,roughness map etc...)
And I set a PointLight and a SpotLight.
It works fine!!
But when I move the SpotLight appropriately,Wings3D was crashed.

The crash log is here.

Code:

Dump written 2019-1-1_16-36
Version: 2.2.1
OS: Windows 8 (build 9200), 64-bit edition
GPU: Intel | Intel(R) HD Graphics 400
Window: geom
Reason: badarg

Short stack trace:
[{io_lib,format,2,[{file,"io_lib.erl"},{line,170}]},
{wings_light,info,1,
              [{file,"c:/Users/familjen/src/wings/src/wings_light.erl"},
               {line,132}]},
{wings_sel,dfold_1,5,
            [{file,"c:/Users/familjen/src/wings/src/wings_sel.erl"},
             {line,235}]},
{wings_info,info,1,
             [{file,"c:/Users/familjen/src/wings/src/wings_info.erl"},
              {line,29}]},
{wings,redraw,1,
        [{file,"c:/Users/familjen/src/wings/src/wings.erl"},{line,263}]},
{wings,handle_event_3,2,
        [{file,"c:/Users/familjen/src/wings/src/wings.erl"},{line,424}]},
{wings_wm,handle_event,3,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,981}]},
{wings_wm,send_event,2,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,948}]},
{wings_wm,do_dispatch,2,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,849}]},
{wings_wm,redraw_win,1,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,890}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1338}]},
{wings_wm,redraw_all,0,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,865}]},
{wings,init_part2,2,
        [{file,"c:/Users/familjen/src/wings/src/wings.erl"},{line,106}]},
{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]

Long stack trace:
[{io_lib,format,
         [": Pos ~ts ~ts ~ts",
          [["<","1.276249","  ","2.836651","  ","-1.273416",">"]]],
         [{file,"io_lib.erl"},{line,170}]},
{wings_light,info,1,
              [{file,"c:/Users/familjen/src/wings/src/wings_light.erl"},
               {line,132}]},
{wings_sel,dfold_1,5,
            [{file,"c:/Users/familjen/src/wings/src/wings_sel.erl"},
             {line,235}]},
{wings_info,info,1,
             [{file,"c:/Users/familjen/src/wings/src/wings_info.erl"},
              {line,29}]},
{wings,redraw,1,
        [{file,"c:/Users/familjen/src/wings/src/wings.erl"},{line,263}]},
{wings,handle_event_3,2,
        [{file,"c:/Users/familjen/src/wings/src/wings.erl"},{line,424}]},
{wings_wm,handle_event,3,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,981}]},
{wings_wm,send_event,2,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,948}]},
{wings_wm,do_dispatch,2,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,849}]},
{wings_wm,redraw_win,1,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,890}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1338}]},
{wings_wm,redraw_all,0,
           [{file,"c:/Users/familjen/src/wings/src/wings_wm.erl"},{line,865}]},
{wings,init_part2,2,
        [{file,"c:/Users/familjen/src/wings/src/wings.erl"},{line,106}]},
{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]

Wings3D v2.2.1(No patched version)
Enviroment: Windows10 (But recored as Windows8 in Crash log)
------------------------------------------------------------------------------
Best Regard.

[micheus]

Thanks tkbd

I couldn't to repeat the problem, but by looking in the dump file (long stack) we see it happens when drawing the status line with the coordinate information for the light; and the format string shown (": Pos ~ts ~ts ~ts") is completely different of the one we can find in the wings_light.erl at the source repository (": Pos ~s") - which is the correct:

Code:

Long stack trace:
[{io_lib,format,
         [": Pos ~ts ~ts ~ts",
          [["<","1.276249","  ","2.836651","  ","-1.273416",">"]]],
         [{file,"io_lib.erl"},{line,170}]},
{wings_light,info,1,
              [{file,"c:/Users/familjen/src/wings/src/wings_light.erl"},
               {line,132}]},

So, by doing a search by that bad format string I found it's present in the language files: wings_jp.lang, wings_ko.lang and wings_zh-cn.lang; Like this for the Japanese one:

Code:

{info,
   [
    % "Light ~ts"
    {1,"Light ~ts"},
    % ": Pos ~ts ~ts ~ts"
    {2,": Pos ~ts ~ts ~ts"}
   ]},

It's fixed now. Check the Fixes for v2.2.1.

[tkbd]

micheus,Thank you for quick response!!
I think back on ... When this bug occurred, I surely set the language to Japanese.
(and also I found that easy way to recreate this bug. Switch to Body selection mode while selecting a Light.)

Then, I download your patchs and new lang files, and tested them.
Simplefied Chinese(zh-cn) and Korean(ko) are now OK.
But Only Japanese(jp) hasn't been fixed yet.
See a line 2007 in wings_jp.lang

{info,
[
% "Light ~ts"
{1,"Light ~ts"},
% ": Pos ~t"
{2,": Pos ~"}
]},

It is missing “s” after “Pos~”.

Another more, would you fix Traditional Chinese(zh-tw) version too?
See a line 1981 in wings_zh-tw.lang .

{info,
[
{1,"光 ~ts"},
{2,"：名次 ~ts ~ts ~ts"}
]},

Parhaps,I think that way all that problem should be solved.

[micheus]

Thanks for checking. It seems I removed too much characters.

I'm going to fix them.

[tkbd]

Thank you very much

[micheus]

I just did a reviewing of all language files and updated them to the fixes repository.

Thanks again.