YafaRay Plug-in - reviewing for Yafaray 3.0

micheus · 10-19-2020, 11:43 AM

No. I probably will need to build it with the previous version of the Erlang compiler.
Sorry for not test replacing it in the official release.

tkbd · 10-20-2020, 10:12 AM

micheus,Thank you for send test version.
I tested this, and some otf/ttf font that has japanese file name, they locate in file path that contains non latin string.
Sometimes I checked the one with the extension removed.
These fonts loading and glyph drawing was successful. Smile

Some of font didn't correct glyph draw, but they were very old formats or demo versions with reduced glyphs intendly.

Next, I tested the badge Icon file path as well.
It was okay if the file and directory names contained non latin string.
So,It's okay for normal using.

At last,I tested for the material and file name that contains in data.
As a result,Yafaray rendering will fail if the 3D object, material, or texture name used contains a non-latin string.

See a following log.
Case: Non latin string with a texture name

Quote:ERROR: Failed to export:
{'EXIT',{badarg,[{io_lib,format,
["<texture name=\"~s\">~n <filename sval=\"~s\"/>~n<type sval=\"image\"/>~n</texture>",
[[[119,95,67,117,98,101,12398,49,97,117,118],95,"1"],
[47,85,115,101,114,115,47,117,115,101,114,47,68,
101,115,107,116,111,112,47,12486,12473,12488,
30011,20687,46,112,110,103]]],
[{file,"io_lib.erl"},{line,187}]},
{wpc_yafaray,println,3,
[{file,"wpc_yafaray.erl"},{line,5854}]},
{wpc_yafaray,'-export_shinydiffuse_shader/5-fun-0-',6,
[{file,"wpc_yafaray.erl"},{line,3325}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
{wpc_yafaray,export_shinydiffuse_shader,5,
[{file,"wpc_yafaray.erl"},{line,3324}]},
{wpc_yafaray,'-export/3-fun-0-',4,
[{file,"wpc_yafaray.erl"},{line,3152}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
{wpc_yafaray,export,3,[{file,"wpc_yafaray.erl"},{line,3151}]},
{wpc_yafaray,'-do_export/4-fun-0-',3,
[{file,"wpc_yafaray.erl"},{line,697}]},
{wings_export,export,4,[{file,"wings_export.erl"},{line,40}]},
{wings_file,'-export_filename_1/2-fun-0-',3,
[{file,"wings_file.erl"},{line,97}]},
{wings_develop,time_command,2,
[{file,"wings_develop.erl"},{line,87}]},
{wings_plugin,command,3,
[{file,"wings_plugin.erl"},{line,147}]},
{wings,raw_command_1,3,[{file,"wings.erl"},{line,644}]},
{wings,raw_command,4,[{file,"wings.erl"},{line,641}]},
{wings_wm,handle_event,3,[{file,"wings_wm.erl"},{line,1030}]},
{wings_wm,send_event,2,[{file,"wings_wm.erl"},{line,996}]},
{wings_wm,do_dispatch,2,[{file,"wings_wm.erl"},{line,888}]},
{wings_wm,dispatch_event,1,
[{file,"wings_wm.erl"},{line,797}]},
{wings_wm,get_and_dispatch,0,
[{file,"wings_wm.erl"},{line,683}]},
{wings,init_part2,3,[{file,"wings.erl"},{line,108}]},
{proc_lib,init_p_do_apply,3,
[{file,"proc_lib.erl"},{line,249}]}]}}

Case:Non latin string with an object name

Quote:wings-2.2.6.1
Using OpenCL via gpu:Name Apple:VSN: OpenCL 1.2 (May 5 2020 21:50:52)
Exporting to: /Users/User/Desktop/wpc_yafaray-1104-CQUHIQ.xml
for render to: //Users/User/Desktop/sample_22.png
ERROR: Failed to export:
{'EXIT',{badarg,[{io,format,
[<0.83.0>,"Mesh ~s: triangulating...",
[[119,95,67,117,98,12398,101,49]]],
[]},
{wpc_yafaray,export_object_1,6,
[{file,"wpc_yafaray.erl"},{line,4427}]},
{wpc_yafaray,'-export/3-fun-2-',4,
[{file,"wpc_yafaray.erl"},{line,3170}]},
{wpc_yafaray,export,3,[{file,"wpc_yafaray.erl"},{line,3169}]},
{wpc_yafaray,'-do_export/4-fun-0-',3,
[{file,"wpc_yafaray.erl"},{line,697}]},
{wings_export,export,4,[{file,"wings_export.erl"},{line,40}]},
{wings_file,'-export_filename_1/2-fun-0-',3,
[{file,"wings_file.erl"},{line,97}]},
{wings_develop,time_command,2,
[{file,"wings_develop.erl"},{line,87}]},
{wings_plugin,command,3,
[{file,"wings_plugin.erl"},{line,147}]},
{wings,raw_command_1,3,[{file,"wings.erl"},{line,644}]},
{wings,raw_command,4,[{file,"wings.erl"},{line,641}]},
{wings_wm,handle_event,3,[{file,"wings_wm.erl"},{line,1030}]},
{wings_wm,send_event,2,[{file,"wings_wm.erl"},{line,996}]},
{wings_wm,do_dispatch,2,[{file,"wings_wm.erl"},{line,888}]},
{wings_wm,dispatch_event,1,
[{file,"wings_wm.erl"},{line,797}]},
{wings_wm,get_and_dispatch,0,
[{file,"wings_wm.erl"},{line,683}]},
{wings,init_part2,3,[{file,"wings.erl"},{line,108}]},
{proc_lib,init_p_do_apply,3,
[{file,"proc_lib.erl"},{line,249}]}]}}

Best regard Smile

micheus · 10-20-2020, 11:39 AM

Thanks for the feedback. I'm going to review all the formatting string for output.

tkbd · 10-21-2020, 08:56 AM

I received a test plugin and I will tell you the result.

I tried test with 3files rendering.
The Yafaray Rendering on use non-latin name ...
(They have simple scene,one textureed cube)
A) with texture file name
B) with 3D Object name
C) with Material name
I'm going to send to you these samples. Smile

I use the non-latin name with Wings3D internal image.
They connected to Cuve1auv the UV as color,roughness,metalness and emission Texture etc...

Yafaray XML file output stopped in the middle.

XML file data is here.

Code:
<?xml version="1.0"?>

<!-- wpc_yafaray-762-RWTIIQ.xml: Exported from Wings 3D 2.2.6.1 -->

<scene type="triangle">

<!-- Section Materials -->

Probably,for some reason ~ts format string is not working well.
Error Log is here in this time.

Code:
Exporting  to: /Users/User/Desktop/wpc_yafaray-762-RWTIIQ.xml

for render to: //Users/User/Desktop/sample_22.png

ERROR: Failed to export:

{'EXIT',{{error,badarg},

         [{wpc_yafaray,println,

                       [<0.227.0>,

                        "<texture name=\"~ts\">~n    <filename sval=\"~ts\"/>~n<type sval=\"image\"/>~n</texture>",

                        [["w_Cube1auv",95,"1"],

                         [47,85,115,101,114,115,47,117,115,101,114,47,68,101,

                          115,107,116,111,112,47,12486,12473,12488,12398,

                          30011,20687,12391,12377,46,112,110,103]]],

                       [{file,"wpc_yafaray.erl"},{line,5858}]},

          {wpc_yafaray,'-export_shinydiffuse_shader/5-fun-0-',6,

                       [{file,"wpc_yafaray.erl"},{line,3325}]},

          {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},

          {wpc_yafaray,export_shinydiffuse_shader,5,

                       [{file,"wpc_yafaray.erl"},{line,3324}]},

          {wpc_yafaray,'-export/3-fun-0-',4,

                       [{file,"wpc_yafaray.erl"},{line,3152}]},

          {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},

          {wpc_yafaray,export,3,[{file,"wpc_yafaray.erl"},{line,3151}]},

          {wpc_yafaray,'-do_export/4-fun-0-',3,

                       [{file,"wpc_yafaray.erl"},{line,697}]},

          {wings_export,export,4,[{file,"wings_export.erl"},{line,40}]},

          {wings_file,'-export_filename_1/2-fun-0-',3,

                      [{file,"wings_file.erl"},{line,97}]},

          {wings_develop,time_command,2,

                         [{file,"wings_develop.erl"},{line,87}]},

          {wings_plugin,command,3,[{file,"wings_plugin.erl"},{line,147}]},

          {wings,raw_command_1,3,[{file,"wings.erl"},{line,644}]},

          {wings,raw_command,4,[{file,"wings.erl"},{line,641}]},

          {wings_wm,handle_event,3,[{file,"wings_wm.erl"},{line,1030}]},

          {wings_wm,send_event,2,[{file,"wings_wm.erl"},{line,996}]},

          {wings_wm,do_dispatch,2,[{file,"wings_wm.erl"},{line,888}]},

          {wings_wm,dispatch_event,1,[{file,"wings_wm.erl"},{line,797}]},

          {wings_wm,get_and_dispatch,0,[{file,"wings_wm.erl"},{line,683}]},

          {wings,init_part2,3,[{file,"wings.erl"},{line,108}]},

          {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}}

This is outoput of the commented-out xml data,
there is an error on the Wings3D side.

Code:
Exporting  to: /Users/User/Desktop/wpc_yafaray-762-XCUIIQ.xml

for render to: //Users/User/Desktop/sample_33.png

Mesh w_Cue1立方体: triangulating...done

Mesh w_Cue1立方体: exporting...ERROR: Failed to export:

{'EXIT',{{error,badarg},

         [{wpc_yafaray,println,

                       [<0.266.0>,"<!--Object Name ~ts, Object # ~w-->",

                        [[119,95,67,117,101,49,31435,26041,20307],1]],

                       [{file,"wpc_yafaray.erl"},{line,5858}]},

          {wpc_yafaray,export_object_1,6,

                       [{file,"wpc_yafaray.erl"},{line,4435}]},

          {wpc_yafaray,'-export/3-fun-2-',4,

                       [{file,"wpc_yafaray.erl"},{line,3170}]},

          {wpc_yafaray,export,3,[{file,"wpc_yafaray.erl"},{line,3169}]},

          {wpc_yafaray,'-do_export/4-fun-0-',3,

                       [{file,"wpc_yafaray.erl"},{line,697}]},

          {wings_export,export,4,[{file,"wings_export.erl"},{line,40}]},

          {wings_file,'-export_filename_1/2-fun-0-',3,

                      [{file,"wings_file.erl"},{line,97}]},

          {wings_develop,time_command,2,

                         [{file,"wings_develop.erl"},{line,87}]},

          {wings_plugin,command,3,[{file,"wings_plugin.erl"},{line,147}]},

          {wings,raw_command_1,3,[{file,"wings.erl"},{line,644}]},

          {wings,raw_command,4,[{file,"wings.erl"},{line,641}]},

          {wings_wm,handle_event,3,[{file,"wings_wm.erl"},{line,1030}]},

          {wings_wm,send_event,2,[{file,"wings_wm.erl"},{line,996}]},

          {wings_wm,do_dispatch,2,[{file,"wings_wm.erl"},{line,888}]},

          {wings_wm,dispatch_event,1,[{file,"wings_wm.erl"},{line,797}]},

          {wings_wm,get_and_dispatch,0,[{file,"wings_wm.erl"},{line,683}]},

          {wings,init_part2,3,[{file,"wings.erl"},{line,108}]},

          {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}}

micheus · (This post was last modified: 10-21-2020, 07:45 PM by micheus.)

tkbd, thank you for the file and your usual help with these unicode issues.

I was able to fix the problems.
I just got one error message on console because of a missing file in your zip (an image from your profile directory), but nothing that stopped the render to finish the task. Smile

tkbd · 10-22-2020, 12:25 PM

micheus,I tested with the latest version you sent me yesterday.
The io-lib format should be correct, but I get the same error log as before.
Rendering failed even though no error should have occurred.... Sad

So , to do a comparative test , I made the data for latin name.
(All datas are not use unicode), and tried rending again.
A following error message output. Maybe this cause the errors.

Code:
Exporting  to: /Users/User/Desktop/yafaray_sample_data/okok/wpc_yafaray-1105-BQQLIQ.xml

for render to: //Users/User/Desktop/yafaray_sample_data/okok/with_tex_namee.png

Mesh w_Cue1: triangulating...done

Mesh w_Cue1: exporting...done

ERROR: Failed to export:

{'EXIT',{badarg,[{io_lib,format,

                         ["<background name=\"t\">",["x_ConstBackground"]],

                         [{file,"io_lib.erl"},{line,187}]},

                 {wpc_yafaray,print,3,[{file,"wpc_yafaray.erl"},{line,5846}]},

                 {wpc_yafaray,export_background,3,

                              [{file,"wpc_yafaray.erl"},{line,5117}]},

                 {wpc_yafaray,export,3,[{file,"wpc_yafaray.erl"},{line,3205}]},

                 {wpc_yafaray,'-do_export/4-fun-0-',3,

                              [{file,"wpc_yafaray.erl"},{line,697}]},

                 {wings_export,export,4,[{file,"wings_export.erl"},{line,40}]},

                 {wings_file,'-export_filename_1/2-fun-0-',3,

                             [{file,"wings_file.erl"},{line,97}]},

                 {wings_develop,time_command,2,

                                [{file,"wings_develop.erl"},{line,87}]},

                 {wings_plugin,command,3,

                               [{file,"wings_plugin.erl"},{line,147}]},

                 {wings,raw_command_1,3,[{file,"wings.erl"},{line,644}]},

                 {wings,raw_command,4,[{file,"wings.erl"},{line,641}]},

                 {wings_wm,handle_event,3,[{file,"wings_wm.erl"},{line,1030}]},

                 {wings_wm,send_event,2,[{file,"wings_wm.erl"},{line,996}]},

                 {wings_wm,do_dispatch,2,[{file,"wings_wm.erl"},{line,888}]},

                 {wings_wm,dispatch_event,1,

                           [{file,"wings_wm.erl"},{line,797}]},

                 {wings_wm,get_and_dispatch,0,

                           [{file,"wings_wm.erl"},{line,683}]},

                 {wings,init_part2,3,[{file,"wings.erl"},{line,108}]},

                 {proc_lib,init_p_do_apply,3,

                           [{file,"proc_lib.erl"},{line,249}]}]}}

tkbd · 10-24-2020, 12:40 PM

micheus,Finally I founded/tried the latest file that you sent to me.
And test it on both of Windows and MacOS.
Yafaray Rendering with non-latin charactors using for resouces data, Icon file and font file Path supports are now OK.

Thank you very much for assiduous and courteous support !!! Smile

----------
tkbd